Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anybody home? (status of this project) #198

Closed
KillyMXI opened this issue Mar 18, 2020 · 16 comments
Closed

Anybody home? (status of this project) #198

KillyMXI opened this issue Mar 18, 2020 · 16 comments

Comments

@KillyMXI
Copy link
Member

It seems like there is no one to provide even basic maintenance and accept PRs.

Maybe it's time to pass on the project to a different maintainer or to fork it in case the former is not possible?

Project activity is weird though. Waiting for some day in April to see another batch of activity and then another year of silence?

@KillyMXI
Copy link
Member Author

KillyMXI commented Mar 29, 2020

Until we have any response, I made a usable fork.

I've updated the dependencies and merged a bunch of patches to my fork:
https://github.com/KillyMXI/node-html-to-text
(Should I open issues and provide support there - I haven't decided yet.)

I've published my fork into a scoped package:
https://www.npmjs.com/package/@mxiii/html-to-text

Anyone who needs a patched version right now - can install it by replacing html-to-text with @mxiii/html-to-text in package.json and at the place of import.

@netmiller
Copy link

Hard to find alternatives AFAIK (for Node). This or fork is quite important in my project.

@KillyMXI
Copy link
Member Author

Yep. I did some research, and all alternative JS packages are either:

  • primitive;
  • outdated;
  • serve different purpose;
  • combination of those.

Nowhere to run.

@mlegenhausen
Copy link
Member

Sorry guys. I am not using this packages anymore by myself and have not the time to further maintain this project. But I am open for contributors that would like the maintain the project.

@KillyMXI
Copy link
Member Author

Yay, finally a response.

I use it for a couple of tiny projects.
I'm not ready to invest into feature development, but at least I'm ready to keep the communication and to keep the package healthy.

@KillyMXI
Copy link
Member Author

KillyMXI commented Apr 2, 2020

I've noticed @madflow (@priotas) is actively working on a separate fork now.
Can they share plans with us?

@madflow
Copy link
Contributor

madflow commented Apr 2, 2020

@KillyMXI We are using this in a non-critical part in one of our products. In my experience: If a package/module is not maintained anymore you can might as well maintain a fork. Since I predict there will be no aspiring maintainers jumping up in order to hack on a html-email-to-text-converter (thanks @mlegenhausen for taking one for the team) I made myself a little bit more comfortable and:

  • Migrated to Typescript
  • Migrated to Jest
  • Removed cli and minimist
  • Removed .fromString
  • Removed Browser support
  • Yarn instead of NPM

Tests pass...

Anyone: Feel free to pull from https://github.com/priotas/html-to-text/tree/next. We will publish this under @priotas/html-to-text

@KillyMXI
Copy link
Member Author

KillyMXI commented Apr 2, 2020

I wonder how many people rely on CLI and browser support.
If there is a need for that, then a separate package is still needed.

I will keep a backwards compatible package.

@netmiller
Copy link

CLI is nice for testing etc, but I need only Nodejs. No need for browser support but I can imagine someone will need.

jbl2024 added a commit to jbl2024/latelier that referenced this issue Apr 5, 2020
- Move from html-to-text to @mxiii/html-to-text (see html-to-text/node-html-to-text#198)
- Upgrade handlebars to 4.7.6
@KillyMXI
Copy link
Member Author

KillyMXI commented Apr 5, 2020

@mlegenhausen If you want an explicit request from a potential maintainer - you have one.

  • few things still itch my OCD;
  • maintaining a fork has limited effect for community;
  • I'm hesitant to diverge far from main code base (any cleanup will make it harder to merge back future contributions).

So I would like to resolve this by maintaining the original package.

(And please don't be silent in case you don't want to approve this and waiting for a better offer.)

@JohnMcLear
Copy link

+1 please resolve this asap :)

@mlegenhausen
Copy link
Member

@KillyMXI I added you as maintainer of the project.

@JohnMcLear
Copy link

JohnMcLear commented Apr 7, 2020

Excellently handled @mlegenhausen and @KillyMXI - credit to you both.

Now let's get this party started 🔢

@KillyMXI
Copy link
Member Author

KillyMXI commented Apr 7, 2020

Thank you.

I will open a tracking issue for the next version in a day, and then start working on it.

Next version going to be 6.0.0. I will keep backwards compatibility, but I might need to bump Node version.

@JohnMcLear
Copy link

@KillyMXI FWIW Etherpad is shifting to require Node10+ in our next release.

@KillyMXI
Copy link
Member Author

KillyMXI commented Apr 8, 2020

I opened #200 to track the progress towards 6.0.0.
Those waiting for new version can subscribe to that issue.
I would expect it to be done in few batches during a week. But I also got some urgent matter to take care of, so there might be little delays.

This issue served it's purpose and closed.

@KillyMXI KillyMXI closed this as completed Apr 8, 2020
jbl2024 added a commit to jbl2024/latelier that referenced this issue Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants