Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken image + name change #10

Closed
notwaving opened this issue Oct 4, 2017 · 3 comments
Closed

Broken image + name change #10

notwaving opened this issue Oct 4, 2017 · 3 comments

Comments

@notwaving
Copy link
Contributor

  1. The image for Unfold Inclusion in UK XR is broken and I can see where it should be when looking at the html in Chrome dev tools; but ndex.html in your repo doesn’t match up with it, and I'm not familiar with Angular.

screen shot 2017-10-04 at 22 10 53

I noticed you're linking images from Meetup, here's Unfold's: https://secure.meetupstatic.com/photos/event/d/f/2/0/highres_460377120.jpeg

  1. I think their name might have changed to Unfold UK https://www.meetup.com/unfolduk/ Happy to amend if I can get into the source code.
@eddiejaoude
Copy link
Contributor

Thanks for spotting 👍 .

I am happy to help support with the fix 🤓 ....

The data is not in the source code but managed by a json data file. Here is a link to the file and the object for this entry, which looks like this...

{
    "name": "Unfold Inclusion in UK XR",
    "description": "Powering inclusion in immersive tech. We're a support network that actively promotes & champions the inclusion of all underrepresented groups in the VR, AR and MR space. Formerly Women in VR UK",
    "url": "https://www.facebook.com/groups/unfolduk/",
    "logo": "https://scontent-otp1-1.xx.fbcdn.net/v/t1.0-9/18485911_10156375476758532_7563742107552031879_n.jpg?oh=072724ab61f485af2fb601d40a0ae0b6&oe=59B3E6A4",
    "social": [
      {
        "name": "twitter",
        "url": "http://twitter.com/UnfoldWomen"
      }
    ],
    "codeOfConduct": "",
    "levels": ["beginner", "intermediate", "advanced"],
    "tags": ["VR", "AR", "Women", "Gender"]
  }

Here are the docs for in the README.md:UpdateData, but probably need some TLC, please can you let me know what is missing in the docs to help onboard more people.

Thanks 😄

@notwaving
Copy link
Contributor Author

Thanks for guiding me through this. I'm blaming late night brain for not a) seemingly opening every file except communities.json; b) scrolling down the page to read the rest of the README...

It was all very easy to follow!

Regarding the actual issue:

  1. Is complete and PR'd.
  2. I checked them on Facebook and they're listed under this long version of their name, so no change has been made.

@eddiejaoude
Copy link
Contributor

Thank you 👍 . PR merged 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants