Modernize code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the code to work with Xcode 12 beta 4 and current version of Swift Package Manager.
|
@jaanus Wow! Sorry I'm just seeing this. Somehow I dropped the ball on this one. Thanks so much for the suggestions. I have a few comments, but I understand it it's been too long since you created this to want to update. If not, I'll put up another PR updating the project a bit. |
wesbillman
reviewed
Jan 19, 2021
| @@ -46,15 +46,14 @@ public class JSONFeed { | |||
| } | |||
|
|
|||
| if let hubsJSON = json["hubs"] as? [[AnyHashable: Any]] { | |||
| self.hubs = hubsJSON.flatMap(Hub.init) | |||
| // self.hubs = hubsJSON.flatMap(Hub.init) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code to work with Xcode 12 beta 4 and current version of Swift Package Manager. (Not sure about other build tools. I only need SPM myself.)