Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to ReadMe to get more clarity #17

Closed
wants to merge 2 commits into from
Closed

Updates to ReadMe to get more clarity #17

wants to merge 2 commits into from

Conversation

rkadam
Copy link
Contributor

@rkadam rkadam commented Jan 1, 2017

Happy New Year Wes!
Going through your commandlinepoweruser videos and on as part of Video 5, started using this theme. I was stuck on Powerline installation and I'm hoping this adds more clarity to help users who like to use theme.

Thank you for sharing.
Raju

@wesbos
Copy link
Owner

wesbos commented Jan 2, 2017

Hey - thanks so much for the edits. These are great edits but not something that I want in my terminal - you can feel free to fork it and make your own theme.

thanks again1

@wesbos wesbos closed this Jan 2, 2017
@rkadam
Copy link
Contributor Author

rkadam commented Jan 2, 2017

Good Morning Wes.

When I created PR, I really wanted to update README in main REPO to get clarity around how to install Powerline Fonts

Later I updated my fork to make changes that I really wanted for myself and committed to fork. But it seems my earlier PR picked up these changes and shown all together. which I didn't want either.

Raju

@wesbos
Copy link
Owner

wesbos commented Jan 2, 2017

Ah - can you submit a new PR with just the readme edits?

@rkadam
Copy link
Contributor Author

rkadam commented Jan 2, 2017 via email

@wesbos
Copy link
Owner

wesbos commented Jan 2, 2017

Yeah - so first make a new branch forked from master.

then git cherry-pick 18d6f64

Then submit a PR from that branch.

Or just edit the readme.md from github again :)

Glad you have been enjoying everything!

@rkadam
Copy link
Contributor Author

rkadam commented Jan 2, 2017

sure thing. Created another PR for README updates #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants