Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed syntax in 'start:...' portion of 20 - Speech Detection packag… #197

Closed
wants to merge 3 commits into from

Conversation

faddah
Copy link

@faddah faddah commented Jan 5, 2018

…e.json file so the command line command doesn't not error out any longer, and updated to the latest version of the browser-sync module in that file.

…e.json file so the command line command doesn't not error out any longer, and updated to the latest version of the browser-sync module in that file.
@wesbos
Copy link
Owner

wesbos commented Jan 5, 2018

I believe we can't use single quotes because of windows users

@faddah
Copy link
Author

faddah commented Jan 9, 2018

Hi @wesbos ,

Thank you for replying.

Well, I don't know what to tell you then, because it fails on MacOS High Sierra 10.13.2 with Node.JS 8.9.3 & NPM 5.6.0 using your former syntax. Are you certain about the Windows OS issue? And could that be resolved by using the unicode characters?

best,

— faddah
portland, oregon, u.s.a.

@faddah
Copy link
Author

faddah commented Jan 9, 2018

@wesbos ,

ok, i've done another version that uses the unicode escape \u0027 for an " ' " in that line in the package.json file. do you want me to close/cancel this PR, and open a new one with that file? that should work on linux/unix/mac/windows. works on my Mac Pro w/ MacOS High Sierra 10.13.2.

please let me know.

best,

— faddah
portland, oregon, u.s.

… characters so it will work from command line in linux, unix, macos and windows. committing prior to push & PR to original repository.
@wesbos wesbos closed this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants