-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Prettier rules are not working. #4
Comments
Hmm - let me take a look into this. You are sure you don't have a prettier config file in your folder? |
I'm testing in a single file in a folder, there's no |
and was this with a global or local install? |
Global install |
Sorry to interject. This might be what is causing the unwanted behaviour:
This line could be taking precedence over the rule you set in from that first link:
(I'm making the leap here that a setting in the settings.json file acts like a global .prettierrc file) edit: the rule in |
hmm I don't recall this being an issue for me and I've always used it this way. Will investigate :) |
Oh - just reading this again and I see the issue. I don't use the prettier vs code extension, and if you followed my steps, you will see that we turned it off. So, if you want to overwrite any settings that I have, you need to do so in your It would then look like this: {
"extends": [
"wesbos"
],
"rules": {
"prettier/prettier": [
"error",
{
"printWidth": 135,
}
]
}
} |
Going to leave this open so I can document how to add custom eslint and prettier settings to overwrite any that my config sets |
I followed the steps and disabled the vs code extension, but I wasn't aware that I have to add the prettier rules to the |
well im glad you logged this issue because that is exactly what I wanted to find out - little sticking points like this is what cause people to abandon tools like this. Glad we could get it figured out! |
Same here. Through some trial and error I realized I could remove the settings from both VS Code and my project's .prettierrc file. Having everything in one place (.eslintrc) is prettier nice! ;) |
Okay ive documented this in the readme now. Opted against using a .prettierrc |
Apparently, it's only taking into account the Prettier default rules. I have the following rule in my
settings.json
:{
"prettier.printWidth": 132,
}
But it's always cutting my lines at 80.
The text was updated successfully, but these errors were encountered: