Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make field grammar creation homogeneous #22

Closed
Bernardo-MG opened this issue Mar 9, 2015 · 2 comments
Closed

Make field grammar creation homogeneous #22

Bernardo-MG opened this issue Mar 9, 2015 · 2 comments
Assignees
@Bernardo-MG
Labels
enhancement
Milestone
CWR File Parser

Comments

@Bernardo-MG
Copy link
Collaborator

The grammar for the fields should be homogeneous. Try to make all of them be created through a method with the same type of parameters (columns, compulsory, name, etc).
@Bernardo-MG Bernardo-MG self-assigned this Mar 9, 2015
@Bernardo-MG Bernardo-MG added this to the Model Parser milestone Mar 12, 2015
@Bernardo-MG Bernardo-MG changed the title Revise field grammars Make field grammar creation homogeneous Mar 17, 2015
@Bernardo-MG
Copy link
Collaborator Author

Dynamic creation of field rules would be easier if all fields expect the same parameters, no matter if they require them or not.

@Bernardo-MG
Copy link
Collaborator Author

The fields factory and the adapter it uses to create fields takes care of this.

Bernardo-MG added a commit that referenced this issue Apr 7, 2015
@Bernardo-MG
Merge pull request #22 from Bernardo-MG/develop
937c70b 
Develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bernardo-MG Bernardo-MG

Labels
enhancement
Projects
None yet
Milestone
CWR File Parser
Development

No branches or pull requests
1 participant
@Bernardo-MG