flex-2.6.2 breaks kservice

[xiangzhai]

Hi flex developers,

kservice-5.29.0 http://download.kde.org/stable/frameworks/5.29/kservice-5.29.0.tar.xz

services/lex.l: In function 'KTraderParse_initFlex':
services/lex.l:160:3: error: implicit declaration of function 'yy_switch_to_buffer' [-Werror=implicit-function-declaration]
services/lex.l:160:24: error: implicit declaration of function 'yy_scan_string' [-Werror=implicit-function-declaration]
services/lex.l: In function 'kiotraderwrap':
services/lex.l:166:3: error: implicit declaration of function 'yy_delete_buffer' [-Werror=implicit-function-declaration]

just like #127

but autogen.sh && ./configure --prefix=/usr && make && make install flex-2.6.1, then rebuilt kservice-5.29.0, it is OK! so it might be flex-2.6.2's issue!

Regards,
Leslie Zhai

[xiangzhai]

lex.l https://github.com/KDE/kservice/blob/master/src/services/lex.l

flex -Pkiotrader -B -i -o lex.c lex.l

https://github.com/KDE/kservice/blob/master/src/CMakeLists.txt#L59

then lex.c

void KTraderParse_initFlex( const char *_code, yyscan_t _scanner )                  
{                                                                                   
  yy_switch_to_buffer( yy_scan_string( _code, _scanner ), _scanner );               
}                                                                                   
                                                                                    
int yywrap( yyscan_t _scanner )                                                     
{                                                                                   
  struct yyguts_t * yyg = (struct yyguts_t*)_scanner;                               
  yy_delete_buffer( YY_CURRENT_BUFFER, _scanner );                                  
  return 1;                                                                         
}

there are kiotrader_switch_to_buffer, kiotrader_scan_string and kiotrader_delete_buffer, so I workaround patch for lex.l:

diff --git a/src/services/lex.l b/src/services/lex.l
index b43adca..516cc4c 100644
--- a/src/services/lex.l
+++ b/src/services/lex.l
@@ -157,12 +157,12 @@ double KTraderParse_putSimplePositiveFloat( char *_str )
 
 void KTraderParse_initFlex( const char *_code, yyscan_t _scanner )
 {
-  yy_switch_to_buffer( yy_scan_string( _code, _scanner ), _scanner );
+  kiotrader_switch_to_buffer( kiotrader_scan_string( _code, _scanner ), _scanner );
 }
 
 int yywrap( yyscan_t _scanner )
 {
   struct yyguts_t * yyg = (struct yyguts_t*)_scanner;
-  yy_delete_buffer( YY_CURRENT_BUFFER, _scanner );
+  kiotrader_delete_buffer( YY_CURRENT_BUFFER, _scanner );
   return 1;
 }

[xiangzhai]

PS: flex-2.6.1 is able to use kiotrader as prefix instead of "yy"
so ArchLinux (use flex-2.6.1 by default) packages does not need to use my workaround patch for lex.l

[westes]

Please confirm that https://github.com/westes/flex/releases/tag/v2.6.3 fixes the issue for you.

[xiangzhai]

Fixed ;-)