Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when compiling with >= C++11 and -Werror,-Wsuggest-override #486

Open
emcrisostomo opened this issue May 29, 2021 · 3 comments
Open

Comments

@emcrisostomo
Copy link

emcrisostomo commented May 29, 2021

As you can see in this MacPorts ticket, lilypond is failing to compile because an error is raised because of FlexLexer.h not using the override specifier on overridden class member declarations.

https://trac.macports.org/ticket/62801

@Mightyjo
Copy link
Contributor

Thanks! I read the issue over at macports.

A couple of PRs in the pipe will make fixing this a lot easier by separating the output language generation into separate skeletons. Right now, a ton of C emissions are built into the code. Even generating C++ is a kludge.

Until we finish separating the code emitters, treat the included FlexLexer.h as a template. If it doesn't fit your needs or your version of C++ make your own copy of it.

Down the line, we'll be able to make a C++11 version of the C++ skeleton that will let you use all the new language features. If you want to make a head start on that take a look at #460.

@emcrisostomo
Copy link
Author

Thank you very much @Mightyjo, I'll have a look at #460.
As far as that port is concerned, treating FlexLexer.h as a template should work easily.

@westes
Copy link
Owner

westes commented Jul 8, 2021

The retargeting patch series has been merged in, albeit under a different set. Do you still have this problem against master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants