Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests stacked looking for "test.${EXEEXT}.txt" data #72

Closed
matzeri opened this issue May 19, 2016 · 11 comments
Closed

Tests stacked looking for "test.${EXEEXT}.txt" data #72

matzeri opened this issue May 19, 2016 · 11 comments
Assignees

Comments

@matzeri
Copy link

matzeri commented May 19, 2016

Testing 2.6.1 on cygwin to allow the tests to be executed I need to
create links like: alloc_extra.exe.txt -> alloc_extra.txt

After the workaround
for i in *.txt ; do ln -s $i ${i/txt/exe.txt} ; done
the test can be run
Testsuite summary for the fast lexical analyser generator 2.6.1

TOTAL: 114
PASS: 68
SKIP: 0
XFAIL: 0
FAIL: 46
XPASS: 0
ERROR: 0

@matzeri
Copy link
Author

matzeri commented May 19, 2016

also other tests have the same problem

  • '[' -f /cygdrive/e/cyg_pub/devel/flex/flex-2.6.1-1.x86_64/src/flex-2.6.1/tests/reject.txt ']'
  • '[' 0 == 1 ']'
  • ./reject_ser.table.exe ././reject_ser.table.exe.tables /cygdrive/e/cyg_pub/devel/flex/flex-2.6.1-1.x86_64/src/flex-2.6.1/tests/reject.txt
    could not open tables file for reading
    FAIL reject_ser.table.exe (exit status: 2)

@westes westes self-assigned this May 19, 2016
@westes
Copy link
Owner

westes commented May 19, 2016

This happens because the test is using the executeable name to generate the input file name. On MSWindows, that is incorrect. I'll have to dig to see how to fix that.

@westes
Copy link
Owner

westes commented May 20, 2016

Have a look at 854459f. I think this fixes the problem. It's not an ideal fix because automake doesn't document how to refer to an individual test by name. I can confirm that this fix doesn't break anything on my linux box; I don't have a Windows host to test on.

@matzeri
Copy link
Author

matzeri commented May 20, 2016

It fixes for a portion of the tests
Replacing also
${TESTNAME%.exe}.tables
completes the need

TOTAL: 114
PASS: 114

@westes
Copy link
Owner

westes commented May 20, 2016

See 5cbe860 and let me know how that works.

@matzeri
Copy link
Author

matzeri commented May 20, 2016

Same
TOTAL: 114
PASS: 114

@westes
Copy link
Owner

westes commented May 20, 2016

So all tests pass with those two changes?

@matzeri
Copy link
Author

matzeri commented May 20, 2016

Correct

@westes
Copy link
Owner

westes commented May 20, 2016

THanks. I'll clean this up and get it on master, then.

@westes
Copy link
Owner

westes commented May 20, 2016

b

@westes westes closed this as completed May 20, 2016
@westes
Copy link
Owner

westes commented May 20, 2016

The fixes noted above are in master and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants