Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bus stop shelter quests are shown for already mapped bus stop platform ways #1259

Closed
zossebart opened this issue Nov 14, 2018 · 4 comments
Closed

Comments

@zossebart
Copy link

zossebart commented Nov 14, 2018

SC shows bus stop shelter quests for nodes with highway=bus_stop (and no shelter tag), even if they are part of a way with public_transport=platform and shelter tag already set.

I think there is no benefit in duplicating the shelter tag to the node if it is already mapped for the bus stop platform way.
Here's an overpass query showing such nodes (look for example in Berlin): http://overpass-turbo.eu/s/DFs

Versions affected
Android 5.1.1 / StreetComplete 8.4

@matkoniecz
Copy link
Member

matkoniecz commented Nov 14, 2018

I thought that correct mapping is to place highway=bus_stop on such areas if one decides to map them

@zossebart
Copy link
Author

The wiki (https://wiki.openstreetmap.org/wiki/Public_transport) says, for compatibility-reasons, highway=bus_stop should be placed on a node additionally to a platform mapped as a way or area. This is mainly for the renderer, because platform ways/areas are (still) not rendered.
I don't see why we should duplicate tags we already attach to platform ways/areas.

@westnordost
Copy link
Member

Then, for the same reason (PTv1 compatibility), the duplication of the shelter tag, and any other tag on the highway=bus_stop node, is not an error, isn't it?
By what particular data consumer this is used, renderer or else, is not really relevant, as the reason for the duplication is backwards compatibilty, not mapnik-renderer-compatibility.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 18, 2018
@zossebart
Copy link
Author

Based on the note in the Wiki ("Note: Because the newer public_transport=* tags are currently not rendered on the main page, using highway=bus_stop is needed for rendering") I thought it is only necessary for the renderer.
But ok, if you decide to tag for PTv1 (in addition to PTv2), the duplication might be justified (although it makes no sense to me).

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants