new quest: adding religion to place_of_worship, fixes #777 #802

matkoniecz · 2018-01-26T23:57:28Z

this quest has high priority as it is both relatively rare and used by major data consumers in a prominent way

For now statistics about religions are from OSM itself. I did it for following reasons

this way countries without real OSM avrtivity are skipped
it automatically handles cases of religions maintaining more/less place of worship than indicated by its religion share
it reflects interest of OSM editors in region
note that as result of factors above it may significantly differ from official religion distribution
data should be easy to update by rerunning the script
I was curious how it may be done and making statistics from OSM data was more interesting than manually collecting data or parsing official data

Open issues

I think that it would be a good idea to extract code shared by AddSportForm and formm for this quest. AbstractAddAttributeForm? (either as separate PR or by adding commit to this one)
I wonder how script used to generate this data should be shared, I guess that link to file in a separate repo linked fom popularReligion.yml header would be the best idea (requires updating this PR to include link)
AFAIK it is the first attempt to directly transform OSM data into country data files - hopefully it is OK
- if for some reason data for all countries is needed, even ones without OSM editors I may try parsing some statistics like one from add missing religion tag to amenity=place_of_worship #777 (comment)
- using official statistics would also be necessary if order on list is supposed to follow official statistics, rather how many amenity=place_of_worship of given religion are mapped in a given country

westnordost

The research for popular religions is not that good. I might look into that tomorrow myself.

westnordost · 2018-01-27T00:26:40Z

...src/main/java/de/westnordost/streetcomplete/quests/religion/AddReligionToPlaceOfWorship.java

+		return "nodes, ways, relations with amenity=place_of_worship and" +
+                " !religion and" +
+                " name and" +
+                " (access !~ private|no)"; // exclude ones without access to general public


You'd still be able to see it from the outside.

I thought about edge cases like PoW in a military base or a prison. Are you sure that it should be dropped?

westnordost · 2018-01-27T00:29:46Z

...main/java/de/westnordost/streetcomplete/quests/religion/AddReligionToPlaceOfWorshipForm.java

+public class AddReligionToPlaceOfWorshipForm extends ImageListQuestAnswerFragment
+{
+	private static final int
+			MAX_DISPLAYED_ITEMS = 24, INITIALLY_DISPLAYED_ITEMS = 8;


I think this is unnecessary. There are less than 24 items and getMaxNumberOfInitiallyShownItems could just return 8.

Yes, it should be dropped in case of extracting only createItems rather than making an abstract class/

westnordost · 2018-01-27T00:31:17Z

res/country_metadata/popularReligions.yml

+IL: [jewish, christian, muslim]
+IN: [hindu, christian, muslim, buddhist, sikh, jain]
+IQ: [muslim]
+IR: [muslim]


You know where Bahai Faith is from?

According to Wikipedia

It initially grew in Iran (Persia) and other parts of the Middle East region, where it has faced ongoing persecution since its inception.[2] Currently it has between 5 and 7 million adherents, known as Bahá'ís, spread out into most of the world's countries and territories

Given persecution in their home area, spread across world and low total numbers it was not surprising that they are not appearing on list of any country (though it may be next weakness of OSM data).

https://en.wikipedia.org/wiki/Iran#Religion

according to statistics center of Iran, Bahais constitute only about 0.37% of Iran

last data mentioned in https://en.wikipedia.org/wiki/Bah%C3%A1%27%C3%AD_Faith_in_Iran is from 1920

The first sentence of this article says "The Bahá'í Faith in Iran is the country's second-largest religion after Islam"

somehow I missed it, I added now bahai in Iran

westnordost · 2018-01-27T00:38:46Z

I think that it would be a good idea to extract code shared by AddSportForm and formm for this quest. AbstractAddAttributeForm? (either as separate PR or by adding commit to this one)

I'd say that this sort method could be put into some static class as a static method.

westnordost · 2018-01-27T00:40:50Z

For now statistics about religions are from OSM itself.

I'd rather use official religion statistics. OSM is very incomplete here.

matkoniecz · 2018-01-27T07:09:15Z

I'd say that this sort method could be put into some static class as a static method.

Done.

matkoniecz · 2018-01-27T08:30:14Z

Now only issue of religion data should remain...

OSM is very incomplete here

I agree, but it seems to me that OSM is incomplete in places that have no OSM editors including StreetComplete users.

The research for popular religions is not that good. I might look into that tomorrow myself.

Is data from http://data.un.org/Data.aspx?q=population+religion&d=POP&f=tableCode%3a28%3bsexCode%3a0&c=2,3,6,8,10,12,14,15,16&s=_countryEnglishNameOrderBy:asc,refYear:desc,areaCode:asc&v=1 significantly better?

westnordost · 2018-01-27T10:23:21Z

Whoa, in what time zone do you live, if you are up at half past one on the one hand but also up at 5, 6,7 and 9 in the morning?

westnordost · 2018-01-27T10:25:51Z

Is data from http://data.un.org/Data.aspx?q=population+religion&d=POP&f=tableCode%3a28%3bsexCode%3a0&c=2,3,6,8,10,12,14,15,16&s=_countryEnglishNameOrderBy:asc,refYear:desc,areaCode:asc&v=1 significantly better?

I don't know, it is a little too detailed and thus maybe hard and a lot of work to go through there. After all, the information we gather should just be used to change the order a bit. I'll search through wikipedia a bit now.

westnordost · 2018-01-27T10:29:33Z

app/src/main/java/de/westnordost/streetcomplete/quests/PriorityList.java

+import de.westnordost.streetcomplete.view.Item;
+
+public class PriorityList {
+    public static List<Item> BuildList(List<Item> allItems, List<String> popularNames){


According to usual Java naming conventions, functions always start with lowercase letters.

Ops, fixed.

matkoniecz · 2018-01-27T10:59:09Z

Whoa, in what time zone do you live

Unfortunately my timezone is not interesting (Poland) and what worse today there was a very interesting and loud noise outside on early morning.

westnordost · 2018-01-27T13:21:43Z

hey, I am back. Spent the last hours to do some extensive research on wikipedia, mostly 💦

Shinto is Japanese folk religion. But another, more important folk religion was left out, Chinese folk religion (aka Chinese traditional religion, Han folk religion, Chinese popular religion, Sheinism), because I guess there are little sources on that.

Also, I have to say my first impression on the popularReligions.yml was wrong, it really for the most part coincides with my research.

matkoniecz · 2018-01-27T14:52:24Z

So it is ready for merging (I know that it may wait for end of the feature freeze) or is there something to do?

BTW, I would recommend adding chinese_folk value to https://wiki.openstreetmap.org/wiki/Key:religion as currently it is neither listed there nor used even once in the OSM data (I am not planning to add this as I have no idea is it a good idea or not).

westnordost · 2018-01-28T18:46:11Z

So it is ready for merging (I know that it may wait for end of the feature freeze) or is there something to do?

Well you forgot to export the metadata. You should test if the religion quest displays and works correctly though. I.e. also in a country where there is a different order than the usual one.

matkoniecz · 2018-01-28T19:01:27Z

You should test if the religion quest displays and works correctly though.

I did it, including making some edits.

also in a country where there is a different order than the usual one

Unfortunately I failed to to this one. Would it make sense to include in CONTRIBUTING.md a checklist what should be done before making a PR?

matkoniecz · 2018-01-28T19:03:46Z

I plan on retesting it in countries with nonstandard religion order (though this time it will be harder to make test edits - is there a better solution than making edit and reverting it with "sorry, test edit"?), but for now my SC install is locked by #812 (comment)

westnordost · 2018-01-28T19:48:30Z

You can turn off auto upload and/or remove authorization so that the app cannot upload changes, then undo.

matkoniecz · 2018-01-28T19:58:03Z

Or disable internet connection and uninstall app before enabling it (my method so far, undo one seems to be far better - thanks, I though that with undo edit + undo edit would still be send).

Anyway, is there some way to examine what edit would be made? I want to catch bugs noticeable only on examining edit made by app - 926a30f (adding building tag always collided with present building=yes, was fixed by rather modifying it)

In past I also had bug that resulted in incorrect changeset description, I am unsure how to catch this without making a real edit.

westnordost · 2018-02-02T20:17:58Z

So tell me when this is tested and can be merged

this quest has high priority as it is both relatively rare and used by major data consumers in a prominent way

…tracting function

…lk, caodai, bahai, jews and sikh around the world (wikipedia) - add Chinese folk religion - sort standard order by worldwide distribution *minus* those already sorted in popularReligions.yml - show only 4 items by default - remove Confucianism: indistinguishable from Chinese folk religion / not really a religion

matkoniecz · 2018-02-03T07:16:52Z

It is rebased and tested and I consider it ready for merge.

westnordost · 2018-02-04T10:14:50Z

merged!

matkoniecz · 2018-02-04T11:17:55Z

Thanks for review and merging!

matkoniecz · 2018-02-04T11:29:04Z

Though, I would still recommend adding chinese_folk value to https://wiki.openstreetmap.org/wiki/Key:religion as currently it is neither listed there nor used even once in the OSM data (I am not planning to add this as I have no idea is it a good idea or not).

westnordost · 2018-02-04T13:17:58Z

Ok

matkoniecz force-pushed the religion branch 3 times, most recently from 774ab67 to 651a232 Compare January 27, 2018 00:09

matkoniecz changed the title ~~new quest: adding religion to place_of_worship~~ new quest: adding religion to place_of_worship, fixes #777 Jan 27, 2018

westnordost reviewed Jan 27, 2018

View reviewed changes

matkoniecz and others added 9 commits February 3, 2018 08:05

new quest: adding religion to place_of_worship

50fd62a

this quest has high priority as it is both relatively rare and used by major data consumers in a prominent way

drop code no longer needed as creating super class was replaced by ex…

7328648

…tracting function

reuse priority list builder - DRY

9b8269e

fix typo

fadba48

follow naming standards

40a0670

allow private PoW

61e75e1

add bahai in Iran

bf2552e

export country metadata

f2a1f7d

matkoniecz force-pushed the religion branch from b21ac26 to f2a1f7d Compare February 3, 2018 07:16

westnordost merged commit e08e5b3 into streetcomplete:master Feb 4, 2018

matkoniecz deleted the religion branch February 4, 2018 11:17

rugk mentioned this pull request Feb 4, 2018

add missing religion tag to amenity=place_of_worship #777

Closed

5 tasks

new quest: adding religion to place_of_worship, fixes #777 #802

new quest: adding religion to place_of_worship, fixes #777 #802

Conversation

matkoniecz commented Jan 26, 2018 • edited

westnordost left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

westnordost commented Jan 27, 2018

westnordost commented Jan 27, 2018

matkoniecz commented Jan 27, 2018

matkoniecz commented Jan 27, 2018

westnordost commented Jan 27, 2018

westnordost commented Jan 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matkoniecz commented Jan 27, 2018

westnordost commented Jan 27, 2018 • edited

matkoniecz commented Jan 27, 2018

westnordost commented Jan 28, 2018

matkoniecz commented Jan 28, 2018

matkoniecz commented Jan 28, 2018

westnordost commented Jan 28, 2018

matkoniecz commented Jan 28, 2018

westnordost commented Feb 2, 2018

matkoniecz commented Feb 3, 2018

westnordost commented Feb 4, 2018

matkoniecz commented Feb 4, 2018

matkoniecz commented Feb 4, 2018

westnordost commented Feb 4, 2018

matkoniecz commented Jan 26, 2018 •

edited

westnordost commented Jan 27, 2018 •

edited