Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client.get method not passing request paramerters #7

Open
bagelbyte opened this issue Nov 16, 2019 · 0 comments
Open

Client.get method not passing request paramerters #7

bagelbyte opened this issue Nov 16, 2019 · 0 comments

Comments

@bagelbyte
Copy link

fast_arrow_auth's client.py is not passing, at the very least, the params dict to the requests.get method. However, this feature did work in the previous version of client.py as found in "fast_arrow". See below for the code in master at the time of this issue:

fast_arrow_auth/client.py:

def get(self, url, params=None):
        '''
        Execute HTTP GET
        '''
        headers = self._gen_headers(self.access_token, url)
        res = requests.get(url, headers=headers)
        return res.json()

fast_arrow\client.py:

def get(self, url=None, params=None, retry=True):
        '''
        Execute HTTP GET
        '''
        headers = self._gen_headers(self.access_token, url)
        res = requests.get(url,
                           headers=headers,
                           params=params,
                           timeout=15,
                           verify=self.certs)
        res.raise_for_status()
        return res.json()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant