Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm identifiers for attributes #84

Closed
westonruter opened this issue Apr 26, 2020 · 1 comment · Fixed by #92 or #95
Closed

Confirm identifiers for attributes #84

westonruter opened this issue Apr 26, 2020 · 1 comment · Fixed by #92 or #95

Comments

@westonruter
Copy link
Owner

We currently have these block attributes:

  • language
  • selectedLines
  • showLines
  • wrapLines

Before we release 1.2 and blocks out in the wild start using these, we should make sure we're happy with them. I realize that showLines is actually live already, but selectedLines and wrapLines are not. I'm thinking the names don't entirely reflect what the properties do. The

Old New Note
selectedLines highlightedLines Because the UI uses “Highlighted Lines”.
showLines showLineNumbers Lines are always shown. It's the numbers that are in view here. This also corresponds with the UI which has “Show Line Numbers”.

I think we can support the showLines as a legacy property name which we automatically copy to showLineNumbers.

@allejo
Copy link
Collaborator

allejo commented Apr 27, 2020

👍 for these new proposed names from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants