Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the cropped image as black and white or even better based on user selection! #72

Closed
saormart opened this issue Oct 23, 2018 · 5 comments

Comments

@saormart
Copy link

As per request based on this topic

Would be a nice feature to add option to filter the cropped image as black and white (Use GPUImage to enhance scanned documents) or something similar !
What I really mean, would be nice to have different options for the user to adjust images manually like the brightness, contrast let's say "Details" (like a fine adjustment)
Note: Based on user selection, let's says that user want to scan a receipt, so we could have some "pre-setting" to process it and give the user a better user experience!

@julianschiavo
Copy link
Contributor

I think this is a great idea! However, a few things:

  1. I feel having tons of options and sliders would over complicate what is currently a nice, focused scanner
  2. This is (kinda) a duplicate of Use GPUImage to enhance scanned documents #49, especially if we only enhance the image rather than add custom adjustment

@saormart
Copy link
Author

At this point I agree with you ! The scanner is awesome! Maybe all this features could be another framework, or may just another separated class to do this kind of job!
I'm trying to figure out a way to do it just like the #49
But anyway, if anybody could contribute with it, and it could be added to the example code would be handy!

@julianschiavo
Copy link
Contributor

I had an example working with GPUImage, I’m waiting for #41 which is almost merged then I’ll send in a PR 😃

@saormart
Copy link
Author

That's a great news ! Let me know when this happen, and I want to test it for sure ! :)

@saormart
Copy link
Author

saormart commented Nov 8, 2018

By the way, I figure out how to do it with opencv2, but if with GPUImage could get better results, I'll move to it ! I'll close this topic due #49

@saormart saormart closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants