delta function for CI was not type-stable #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be used for GPU executions, otherwise the code could not compile. This fix makes delta type stable and there is no need to inline the function. No noticeable performance change.
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 8 8
Lines 382 382
=======================================
Hits 358 358
Misses 24 24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
How surprising. Are there other places where this is the case where we should be using |
|
Not sure really... I caught this one by chance when writing the blog post. Since it seems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
@inlinehad to be used inWaterLily.jl/src/util.jl
Line 13 in 28b5a38
for the GPU code to compile, differently from CPU where this was not needed.
I rose this issue JuliaGPU/KernelAbstractions.jl#392 and it was pointed out that
δ(d,I::CartesianIndex{N})was type-unstable. This fix makes it type-stable.