Fix mouse scroll on hovered but unfocused pane #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wez, I just wanted to bring my PR to your attention and see if there's anything else I should update or improve. I totally understand that you're a busy person, so no rush at all 😄 Thanks for your time and all the work you do on wezterm. I appreciate any feedback you can provide when you have a moment. |
|
Looks good, thanks! |
wez
added a commit
that referenced
this pull request
Jan 22, 2024
|
Many thanks! The scroll works now. Unfortunately, only partially, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2373
Scrolling a non-focused pane with the mouse wheel wasn't working. It turns out we are detecting the hovered pane, and
perform_key_assignmentdoes have the hovered pane, but it just wasn't passing this information in toscroll_by_current_event_wheel_delta. This resulted inscroll_by_linerepeating the operation to get the current pane, and this doesn't have the hovering logic.The fix is to pass the pane along in the call to
scroll_by_current_event_wheel_delta, and it's subsequent call toscroll_by_line