Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored undercurl and underline on WSL2 / updated ConPTY #4400

Open
lostl1ght opened this issue Oct 5, 2023 · 7 comments
Open

Colored undercurl and underline on WSL2 / updated ConPTY #4400

lostl1ght opened this issue Oct 5, 2023 · 7 comments
Labels
conpty enhancement New feature or request Windows Issue applies to Microsoft Windows

Comments

@lostl1ght
Copy link

lostl1ght commented Oct 5, 2023

Hello!

Is your feature request related to a problem? Please describe.
No colored underline support on WSL2.

Describe the solution you'd like
From my understanding this PR finally added colored underline support to ConPTY.
Can you, please, update bundled ConPTY or guide me through updating it myself?

Describe alternatives you've considered
Ssh'ing to WSL2 which is a different can of worms. :(

Additional context
Also, by the looks of it, the PR did not make into a release, so downloading OpenConsole.exe from release files does not work.
Additionally, maybe this PR can clarify some details.

@lostl1ght lostl1ght added the enhancement New feature or request label Oct 5, 2023
@lostl1ght
Copy link
Author

lostl1ght commented Oct 5, 2023

I think I've figured it out.

I've followed build instructions here.
I've built Release x64 CascadiaPackage using Visual Studio 2022, put conpty.dll and OpenConsole.exe from bin/x64/Release into Wezterm's folder and it just worked™.

Building the entire solution may fail but only conpty.dll and OpenConsole.exe are needed.

The result:
image

@lostl1ght lostl1ght changed the title Updated ConPTY Colored undercurl and underline on WSL2 / updated ConPTY Oct 5, 2023
@chtenb
Copy link
Sponsor

chtenb commented Oct 24, 2023

Would this also work for curly underline support in native windows?

@lostl1ght
Copy link
Author

lostl1ght commented Oct 24, 2023

Looks like it would not.

Powershell run from wezterm:
image

WSL:
image

@antoineco
Copy link
Sponsor

@lostl1ght thanks for sharing! Is anything stopping you from updating the pre-built files at https://github.com/wez/wezterm/tree/6a58a5ce94f186884ec70a60b5afbd728521b1c5/assets/windows/conhost?

@Parsifa1
Copy link

Parsifa1 commented Dec 9, 2023

i tried use newest openconsole.exe and conpty.dll, But it doesn't seem to work

@wez wez added Windows Issue applies to Microsoft Windows conpty labels Feb 4, 2024
@Pytness
Copy link

Pytness commented Apr 10, 2024

@lostl1ght could you share which commit did you use to build it? Im having trouble replicating your results.

@antoineco
Copy link
Sponsor

For people who still follow this thread, the bundled copies of conpty.dll and OpenConsole.exe were both updated in e7fe7c0 to the version that ships with Windows Terminal 1.19.240130002.

Undercurl seems to now be working without issues in WezTerm nightly, as showcased in the following discussion:

#4989 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conpty enhancement New feature or request Windows Issue applies to Microsoft Windows
Projects
None yet
Development

No branches or pull requests

6 participants