Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter handling of Last-Modified #18

Closed
wezm opened this issue Apr 30, 2022 · 0 comments
Closed

Smarter handling of Last-Modified #18

wezm opened this issue Apr 30, 2022 · 0 comments

Comments

@wezm
Copy link
Owner

wezm commented Apr 30, 2022

Currently (in the Rust version) the Last-Modified header is set to the mtime of the document. A failure mode here is if a new version of the application is deployed that alters the way pages are rendered requests with If-Modified-Since will still be considered fresh. Seems like Last-Modified should be set to max(page_mtime, build_date) where build date is a timestamp set when the binary was compiled.

@wezm wezm closed this as completed in 3734b8b May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant