Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return of ring_span's copy_popper<T>::operator() #91

Closed
martinmoene opened this issue May 5, 2017 · 3 comments · Fixed by #108
Closed

Fix return of ring_span's copy_popper<T>::operator() #91

martinmoene opened this issue May 5, 2017 · 3 comments · Fixed by #108

Comments

@martinmoene
Copy link

in:

template <typename T>
T sg14::copy_popper<T>::operator()(T& t)
{
	T old = t;
	t = copy;
	return t;
}

shouldn't return t be return old?
@TBBle
Copy link
Contributor

TBBle commented May 6, 2017

Current code matches the proposal, so it would need to be fixed in both places.

@martinmoene martinmoene mentioned this issue May 11, 2017
Merged
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 14, 2017
@Quuxplusone
Fix behavior of ring_span's copy_popper<T>, and general popper cleanup.
66cc644 
Fixes WG21-SG14#91. Apparently the typo `t` for `old` is also in the current
paper http://wg21.link/p0059r3 — we should fix that too!
Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 14, 2017
@Quuxplusone
Fix behavior of ring_span's copy_popper<T>, and general popper cleanup.
b08b6ab 
Fixes WG21-SG14#91. Apparently the typo `t` for `old` is also in the current
paper http://wg21.link/p0059r3 — we should fix that too!

Fixes WG21-SG14#102.
@Quuxplusone
Copy link
Contributor

Fixed in 5013c6c

Quuxplusone added a commit to Quuxplusone/SG14 that referenced this issue May 19, 2017
@Quuxplusone
Fix behavior of ring_span's copy_popper<T>, and general popper cleanup.
aba9766 
Fixes WG21-SG14#91. Apparently the typo `t` for `old` is also in the current
paper http://wg21.link/p0059r3 — we should fix that too!

Fixes WG21-SG14#102.
@Quuxplusone
Copy link
Contributor

Oops, never mind; this is in a different PR of mine now.

@Quuxplusone Quuxplusone reopened this May 19, 2017
@Quuxplusone Quuxplusone mentioned this issue May 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix behavior of ring_span's copy_popper<T>, and general popper cleanup. Quuxplusone/SG14
3 participants
@TBBle @Quuxplusone @martinmoene