Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional file validation #1

Closed
daneren2005 opened this issue Jun 6, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@daneren2005
Copy link

commented Jun 6, 2018

In my case where I was trying to zip up thousands of photos at once, the file validation was making it take 2-3 minutes before the zip actually started streaming. While I get the value of making sure all of the files exist before doing this, I think it makes sense to have an option to silently skip those files during streaming instead of trying to validate them all up front.

@giovanigenerali

This comment has been minimized.

Copy link
Member

commented Jun 9, 2018

@daneren2005 I'm going to take a look at this, thanks!

@giovanigenerali

This comment has been minimized.

Copy link
Member

commented Jun 9, 2018

@daneren2005 take a look at v2.0.0, now you can set to skip validation of the object.

@daneren2005

This comment has been minimized.

Copy link
Author

commented Jun 11, 2018

Sweet that works great. Thank you for the fast fix for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.