New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Show indepth exercise history changes #1082
Draft: Show indepth exercise history changes #1082
Conversation
Awesome! I'll probably only be able to look at this in two weeks (there's some birthdays coming and next week we're going to airbeat one 😍) |
Yeah all good. Have fun. :) |
Hey, was planning on adding support for created, updated and deleted exercises on the this page an option to revert each action. Just realised when you delete a model it also deletes all the actstream actions for the model. Looking at their closed issues it seems like they don't want to support an option to keep them when you delete the model as well. So, I would have to swap around the logic to have the history models know about the activity streams. Just checking with you if you think having the option to revert deletions is worth it as well, guess we wouldn't know who deleted it as the activity streams would be gone, but having an option to add it back would be nice. |
mhh I would say it is OK if we lose the information when an exercise is deleted. This will be only done by admins and we don't need to document everything, we're not a bank |
Yeah makes sense, sounds good. I'll clean it up and make sure everything works tomorrow. |
We now just load the object history by the timestamp when the activity stream actions were created
(also fixes some tests)
…s for an exercise
I simplified the logic here so that we don't need to explicitly save the history ID. I'm trying to finish everything left on the crowdsourcing branch so we can finally finally realease that stuff. In any case thanks again for the PR |
Proposed Changes
Please check that the PR fulfills these requirements
Other questions
When trying to access the revert_url on the history object at the moment it displays
Here's a video of it currently.
Shows updating exercise object id 1 author and description and then only reverting the license author.
2022-06-30.12-32-51.mp4