Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting the default gym crashes the application #539

Closed
rolandgeider opened this issue Oct 7, 2020 · 4 comments
Closed

Deleting the default gym crashes the application #539

rolandgeider opened this issue Oct 7, 2020 · 4 comments

Comments

@rolandgeider
Copy link
Member

If the default gym is deleted, the application crashes. Either

  • don't show the delete Buttons if the gym list has only one entry

  • see which foreign key makes problems when there are no gyms in the DB

@aitorres
Copy link

aitorres commented Oct 8, 2020

Hello! May I take this issue? I can work on it during today and tomorrow, and submit a PR

@rolandgeider
Copy link
Member Author

It's all yours :)

@aitorres
Copy link

aitorres commented Oct 8, 2020

I just did the following:

  1. Downloaded and set up the repository's development environment, pulling from master
  2. Bootstrapped the app
  3. Log in as admin / admin
  4. Went on to Administration > Gyms
  5. Deleted the "Default gym" and confirmed the deletion
  6. The gym was deleted smoothly, I didn't receive an error or crash, and now the list properly says that no gym has been found

I couldn't replicate the issue :-( let me know if I am doing something wrong or more information on how to get this error if you have

@rolandgeider
Copy link
Member Author

I'll try to reproduce it and go back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants