Skip to content
This repository has been archived by the owner on May 9, 2022. It is now read-only.

Commit

Permalink
fix traceback for transaction problems with one package (#1047005)
Browse files Browse the repository at this point in the history
It's possible that pkg2 will be None here, so we need to handle that
case without crashing.
  • Loading branch information
wgwoods committed Jan 23, 2014
1 parent a595375 commit 7972b6f
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions fedup/download.py
Expand Up @@ -296,10 +296,15 @@ def format_replacement(po):

done = set()
for pkg1, pkg2, err in self.po_with_problems:
if (pkg1,pkg2) not in done:
if (pkg1,pkg2) in done:
continue
if pkg2 is not None:
problems.append("%s requires %s" % (format_replacement(pkg1),
format_replacement(pkg2)))
done.add((pkg1,pkg2))
else:
problems.append("%s has depsolving problems" % \
format_replacement(pkg1))
done.add((pkg1,pkg2))

return problems

Expand Down

0 comments on commit 7972b6f

Please sign in to comment.