Flake8 ignore

[briancohan]

Reduced the number of error codes ignored by flake8 in the tox.ini file.

The main goal was to add more structure to the docstrings, however additional codes were removed. No functional changes were made in the codebase. The only "code" that was changed what altering the tests from assert <cond> == True to assert <cond> is True.

For the error codes that remain, the meaning of the error codes has been provided in tox.ini.

[eniraa]

Wouldn't it be more pythonic to use assert <cond> directly? Or is there actually a need to check that these tests result in booleans?

[eniraa]

Should be Example rather than Exmple.

[briancohan]

Wouldn't it be more pythonic to use assert <cond> directly? Or is there actually a need to check that these tests result in booleans?

Probably, but the specific error code is checking for == when True/False/None are used. I was just trying to reduce the number of ignored styles.

[VagishVela]

Looks good!

One comment, be careful when using is vs ==, as is will work for cached values such as a or true but not for values such as [1].

[VagishVela]

@briancohan Just wondering why the switch from == to is, as we will still need to use == if we are comparing two objects or arrays, as is will return false.

[briancohan]

@briancohan Just wondering why the switch from == to is, as we will still need to use == if we are comparing two objects or arrays, as is will return false.

I don't think the == vs. is applies to most comparisons. My understanding is just when True/False/None are involved (though I could be wrong). If we find this to be an actual issue, then by all means, we can revert the code.