Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to target a specific number, without the need to include in your phonebook #133

Closed
xandao-dev opened this issue Feb 24, 2020 · 10 comments · Fixed by #256
Closed
Assignees
Labels
enhancement New feature or request gssoc21 hard advance issue

Comments

@xandao-dev
Copy link
Collaborator

image

@xandao-dev xandao-dev added enhancement New feature or request gssoc21 labels Feb 24, 2020
@rpotter12 rpotter12 added the medium average issue label Feb 29, 2020
@xandao-dev xandao-dev added hard advance issue and removed medium average issue labels Mar 1, 2020
@SubhradeepSS
Copy link
Contributor

@xandao6 @rpotter12 I would like to work on this issue.
Can you please help a bit about how to begin?

@xandao-dev
Copy link
Collaborator Author

You need to detect when users write a number instead a string, then you need to open a new page with the url: wa.me/number.

@xandao-dev
Copy link
Collaborator Author

You need to work with browser_config.py and little with target_search.py

@SubhradeepSS
Copy link
Contributor

@xandao6 can u please extend the deadline for the completion of the issue?

@xandao-dev
Copy link
Collaborator Author

Extended +4d

@SubhradeepSS
Copy link
Contributor

You need to work with browser_config.py and little with target_search.py

Can you explain a bit more as I have not worked on web,therefore facing difficulty?

@xandao-dev
Copy link
Collaborator Author

what is the problem?

@xandao-dev
Copy link
Collaborator Author

xandao-dev commented Mar 7, 2020

user write a number instead a string -> make this differentiation with logic
When its number you need to create a new tab, there is a function to do that in browser_config
Then you need to load the url: wa.me/number, also there is a function in browser_config
Wait the page to load and it's done.

All this logic above you can put in target_search beetween the current search target method I think.

@xandao-dev
Copy link
Collaborator Author

how is it going?

@Rits1272
Copy link
Contributor

May I work on this issue @xandao6 @rpotter12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc21 hard advance issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants