Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Node#appendSibling/prependSibling #38

Closed
xlaywan opened this issue May 31, 2015 · 7 comments
Closed

Proposal: Node#appendSibling/prependSibling #38

xlaywan opened this issue May 31, 2015 · 7 comments

Comments

@xlaywan
Copy link

xlaywan commented May 31, 2015 

element.appendSibling(sibling)

Good way to replace non-standard insertAdjacentElement.
@annevk
Copy link
Member

annevk commented Jun 1, 2015

This is before/after, no?

@xlaywan
Copy link
Author

xlaywan commented Jun 1, 2015

Yes. This is a better naming?

@ArkadiuszMichalski
Copy link
Contributor

insertAdjacentElement It has been standardized:
http://www.w3.org/TR/DOM-Parsing/#widl-Element-insertAdjacentHTML-void-DOMString-position-DOMString-text

@xlaywan
Copy link
Author

xlaywan commented Jun 1, 2015

There is only insertAdjacentHTML.

@annevk
Copy link
Member

annevk commented Jun 9, 2015

I don't think this is necessarily better naming. Are there libraries that use these names?

@xlaywan
Copy link
Author

xlaywan commented Jun 9, 2015

I have not found any popular libraries.

@annevk
Copy link
Member

annevk commented Jun 9, 2015

Let's leave them as-is then.

@annevk annevk closed this as completed Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @ArkadiuszMichalski @xlaywan