Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow <menu>, <ul>, <ol>, <li> to attach shadow #676

Open
Zhang-Junzhi opened this issue Aug 9, 2018 · 3 comments
Open

Allow <menu>, <ul>, <ol>, <li> to attach shadow #676

Zhang-Junzhi opened this issue Aug 9, 2018 · 3 comments
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: shadow Relates to shadow trees (as defined in DOM)

Comments

@Zhang-Junzhi
Copy link

Zhang-Junzhi commented Aug 9, 2018 •
edited

I don't think any user agents use their shadow root on these elements. I am wondering if there's some other reason for not allowing menu, ul, ol, li to call attachShadow, which I may have missed. Thanks.
@annevk annevk added topic: shadow Relates to shadow trees (as defined in DOM) needs implementer interest Moving the issue forward requires implementers to express interest addition/proposal New features or enhancements labels Aug 10, 2018
@Zhang-Junzhi Zhang-Junzhi changed the title Allow <ul>, <ol>, <li> to attach shadow Allow <menu>, <ul>, <ol>, <li> to attach shadow Aug 14, 2018
@annevk
Copy link
Member

annevk commented Oct 25, 2018

F2F feedback: implementers want a reason / use case for this before considering it.

@deanedwards
Copy link

I just tried to do this, got an error, and google led me here. Nice to see you again Anne. :)

Out of interest, what is the reason for forbidding shadow on some elements? Shouldn't it be a case of caveat emptor when using custom elements?

@annevk
Copy link
Member

annevk commented Nov 20, 2019 •
edited

The main reason is that there's complicated interactions with the existing behavior of some of these elements. We also haven't properly integrated shadow trees throughout the entire system yet (there's a number of open issues against HTML for instance).

Edit: nice to see you again too by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest topic: shadow Relates to shadow trees (as defined in DOM)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @deanedwards @Zhang-Junzhi