Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iso-2022-jp decoder, "trail byte" case says to prepend byte in the end of stream step #164

Closed
mrmixer opened this issue Nov 30, 2018 · 2 comments

Comments

@mrmixer
Copy link

mrmixer commented Nov 30, 2018

In the iso-2022-jp decoder, in the "trail byte" case, when byte is "end of stream", the spec says to prepend the byte (which is end-of-stream) to the stream. Am I misunderstanding ? If not why are we doing that ?

@annevk
Copy link
Member

annevk commented Nov 30, 2018

Because it's an error condition we want to return an error and then reprocess the end-of-stream in the Lead byte byte where it'll return finished.

@mrmixer
Copy link
Author

mrmixer commented Nov 30, 2018

Thanks.

@mrmixer mrmixer closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants