Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require taking a lock to remove an entry #138

Open
a-sully opened this issue Jun 22, 2023 · 1 comment
Open

Require taking a lock to remove an entry #138

a-sully opened this issue Jun 22, 2023 · 1 comment

Comments

@a-sully
Copy link
Collaborator

a-sully commented Jun 22, 2023

The removeEntry() algorithm currently does not lock the removed entry. This means that, for example, a file with an open FileSystemWritableFileStream may be removed... at least according to the spec. Chromium and Firefox both reject with a NoModificationAllowedError in this case (and FileSystemWritableFileStream is not implemented on Safari)

removeEntry() may remove either a file or a directory. Support for locking a directory is tracked in #137

This also applies to the remove() method, which is being specified in #9

@a-sully
Copy link
Collaborator Author

a-sully commented Jun 22, 2023

#73 would fix this for removeEntry()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant