Skip to content

Commit

Permalink
Make window.window/frames/self deal with no browsing context
Browse files Browse the repository at this point in the history
Before this change these getters did not account for Window object's browsing context potentially being null, resulting in a conceptual crash.

Language from tc39/ecma262#702.

Tests: web-platform-tests/wpt#15720.

Helps with #4363.
  • Loading branch information
annevk committed Oct 16, 2019
1 parent 133607f commit 89b7e23
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions source
Original file line number Diff line number Diff line change
Expand Up @@ -3015,6 +3015,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-execution-contexts">JavaScript execution context</dfn></li>
<li><dfn data-x-href="https://tc39.es/ecma262/#execution-context-stack">JavaScript execution context stack</dfn></li>
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-code-realms">JavaScript realm</dfn></li>
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-lexical-environments">EnvironmentRecord</dfn></li>
<li><dfn data-x-href="https://tc39.es/ecma262/#sec-built-in-function-objects">NewTarget</dfn></li>
<li><dfn data-x-href="https://tc39.es/ecma262/#running-execution-context">running JavaScript execution context</dfn></li>
<li><dfn data-x-href="https://tc39.es/ecma262/#surrounding-agent">surrounding agent</dfn></li>
Expand Down Expand Up @@ -79756,9 +79757,10 @@ dictionary <dfn>WindowPostMessageOptions</dfn> : <span>PostMessageOptions</span>
<span>browsing context</span>.</span></p>

<p>The <dfn><code data-x="dom-window">window</code></dfn>, <dfn><code
data-x="dom-frames">frames</code></dfn>, and <dfn><code data-x="dom-self">self</code></dfn> IDL
attributes, on getting, must all return this <code>Window</code> object's <span>browsing
context</span>'s <code>WindowProxy</code> object.</p>
data-x="dom-frames">frames</code></dfn>, and <dfn><code data-x="dom-self">self</code></dfn>
attributes' getters must return this <code>Window</code> object's <span
data-x="concept-relevant-realm">relevant Realm</span>.[[GlobalEnv]]'s
<span>EnvironmentRecord</span>'s [[GlobalThisValue]].</p>

<p>The <dfn><code data-x="dom-document">document</code></dfn> IDL attribute, on getting, must
return this <code>Window</code> object's <span data-x="concept-document-window">associated
Expand Down

0 comments on commit 89b7e23

Please sign in to comment.