Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "rendering suppression for view transitions" also suppresses "perform pending transition operations" #10186

Closed
nt1m opened this issue Mar 8, 2024 · 7 comments

Comments

@nt1m
Copy link
Member

nt1m commented Mar 8, 2024

What is the issue with the HTML Standard?

It would only run "perform pending transition operations" once then for the next rendering update loop, the document would be filtered out

@nt1m
Copy link
Member Author

nt1m commented Mar 8, 2024

cc @khushalsagar @vmpstr

@nt1m
Copy link
Member Author

nt1m commented Mar 8, 2024

Tangentially related concern from @mattwoodrow :

Might be worth some more spec clarification though, since it clearly asks for a 'live' snapshot, but also is suggesting that we'd block animations from running. It seems somewhat weird to me that using JS to edit styles while a VT is running would show up, but using a transition/animation (outside of the VT animation that is) would not.

@nt1m
Copy link
Member Author

nt1m commented Mar 8, 2024

cc @noamr @bokand

@noamr
Copy link
Contributor

noamr commented Mar 8, 2024

The flow goes like this:

So in essence, activating the transition doesn't necessarily happen in "perform pending transition operations", so it won't be blocked by the suppression flag. The suprression is to freeze the rendering while the new state is updating during the course of the author provided update callback.

Happy to discuss/clarify this further.

@nt1m
Copy link
Member Author

nt1m commented Mar 10, 2024

Ah thanks. I think confusion came from the fact that the first definition you see in the CSS spec for "rendering suppression for view transitions" mentions redirecting hit-testing, which I (sensibly?) assumed would be done the duration of the whole view transition.

Perhaps the concept could be renamed to detail more precisely why rendering is being suppressed in the context of VT

@nt1m nt1m closed this as completed Mar 10, 2024
@nt1m
Copy link
Member Author

nt1m commented Mar 11, 2024

@noamr @khushalsagar What is this rendering suppression supposed to avoid?

@khushalsagar
Copy link
Contributor

It ensures the browser is not rendering frames while the author is asynchronously updating the DOM to the new state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants