New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"object getStartDate()" should be "Date getStartDate()" #3340

Closed

mmotorny opened this issue Jan 11, 2018 · 2 comments

mmotorny commented Jan 11, 2018

Actual text

https://html.spec.whatwg.org/multipage/media.html#media-elements:idl-object

object getStartDate();

Proposed text

Date getStartDate();

Rationale

The description of the method says that it must return a new Date object, see https://html.spec.whatwg.org/multipage/media.html#dom-media-getstartdate.
Safari returns Date, see https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/html/HTMLMediaElement.idl#L76.
Chrome is planning to return Date, see https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/media/HTMLMediaElement.idl?rcl=d9f90c9b2ea6dd588717556b1a2db9cd51c9f88b&l=64.

The text was updated successfully, but these errors were encountered:

Member

annevk commented Jan 11, 2018

In IDL Date is not a type. It got removed at some point: whatwg/webidl#69.

Member

domenic commented Jan 11, 2018

Closing, as the spec seems fine here. It still returns a Date, which is a type of object.

domenic closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment