Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome's registerProtocolHandler web+ handling is at odds with the specification #4524

Closed
annevk opened this issue Apr 11, 2019 · 4 comments
Closed

Chrome's registerProtocolHandler web+ handling is at odds with the specification #4524

annevk opened this issue Apr 11, 2019 · 4 comments
Labels
interop Implementations are not interoperable with each other

Comments

@annevk
Copy link
Member

annevk commented Apr 11, 2019

In particular it doesn't restrict the remaining code points to ASCII lower alphas, but allows anything that matches https://url.spec.whatwg.org/#url-scheme-string.

Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1541909.
@annevk annevk added the interop Implementations are not interoperable with each other label Apr 11, 2019
@gijsk
Copy link

gijsk commented Apr 11, 2019

There seem to be no web-platform tests that actually check anything about allowed characters in the web+ scheme versions beyond disallowing "web+" (ie without a suffix) and allowing "web+myprotocol".

@annevk annevk added the needs tests Moving the issue forward requires someone to write tests label Apr 11, 2019
@ericlaw1979
Copy link
Contributor

https://crbug.com/1019995

@ericlaw1979
Copy link
Contributor

The Chromium CL aligns with the spec and Firefox and includes an update to the Web Page Tests.
https://chromium-review.googlesource.com/c/chromium/src/+/2009825/

@annevk annevk removed the needs tests Moving the issue forward requires someone to write tests label Jan 20, 2020
@annevk
Copy link
Member Author

annevk commented Jan 20, 2020

Thanks for getting this resolved Eric!

@annevk annevk closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interop Implementations are not interoperable with each other
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gijsk @annevk @ericlaw1979