Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images' "Reacting to environment changes" step 5 is triggering spurious downloads #4646

Open
yoavweiss opened this issue May 21, 2019 · 0 comments
Labels
interop Implementations are not interoperable with each other needs tests Moving the issue forward requires someone to write tests topic: img

Comments

@yoavweiss
Copy link
Collaborator

While investigating crbug.com/960633, I realized that the current spec language results in spurious downloads in cases where the image is a no-store or that the cache is disabled.

In Reacting to environment changes, step 5 indicates that only when the chosen URL and image density are the same as before, should the algorithm return without loading a new image. However, for "w" descriptor images with a "vw"-based sizes, every viewport change also results in an image density change, triggering the image's reload.
Those reloads are typically "invisible" as the image is still found in the list of available images, but that breaks when that images cannot be fetched from the cache (as mentioned above, no-store and devtools are cases where I see this happening).

/cc @zcorpan

@annevk annevk added interop Implementations are not interoperable with each other needs tests Moving the issue forward requires someone to write tests topic: img labels May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interop Implementations are not interoperable with each other needs tests Moving the issue forward requires someone to write tests topic: img
Development

No branches or pull requests

2 participants