Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parameter in the steps of "7.10.5.8 [[Set]] ( P, V, Receiver )" #6873

Closed
yvt opened this issue Jul 17, 2021 · 3 comments
Closed

Missing parameter in the steps of "7.10.5.8 [[Set]] ( P, V, Receiver )" #6873

yvt opened this issue Jul 17, 2021 · 3 comments
Labels
good first issue Ideal for someone new to a WHATWG standard or software project

Comments

@yvt
Copy link
Contributor

yvt commented Jul 17, 2021

https://html.spec.whatwg.org/multipage/history.html#location-set

If ! IsPlatformObjectSameOrigin(this) is true, then return ? OrdinarySet(this, P, Receiver).

A parameter is missing from this invocation.

https://tc39.es/ecma262/#sec-ordinaryset

10.1.9.1 OrdinarySet ( O, P, V, Receiver )
@yvt yvt mentioned this issue Jul 19, 2021
Closed
@domenic domenic added the good first issue Ideal for someone new to a WHATWG standard or software project label Jul 19, 2021
@Aryan-Mohanty
Copy link
Contributor

Hey, can I know how can I make changes, I am not able to find that particular file where it is present, please help, beginner here!

@yvt
Copy link
Contributor Author

yvt commented Jul 23, 2021

File source, line 86156.

@annevk
Copy link
Member

annevk commented Jul 23, 2021

Fixed by 3650a12.

@annevk annevk closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Ideal for someone new to a WHATWG standard or software project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing parameter in "7.10.5.8 [[Set]] ( P, V, Receiver )" yvt/html
4 participants
@domenic @annevk @yvt @Aryan-Mohanty