-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the type of opener
in Window object idl block description
#8263
Comments
e690fe8 changed it from WindowProxy to any, citing https://www.w3.org/Bugs/Public/show_bug.cgi?id=21946. But I'm not sure it holds in 2022 when both WebKit and Blink has WindowProxy/Window:
@domenic, thoughts? |
Oh, actually both WebKit and Blink has a custom setter behavior where random things are allowed to be assigned. Probably too dangerous to change that then. |
Note that there is https://github.com/web-platform-tests/wpt/blob/master/html/browsers/windows/auxiliary-browsing-contexts/resources/opener-setter.html an explicit test to check if you can set it to a string, |
WindowProxy is not a defined IDL type, so while implementations may use it for some sort of codegen, I don't think it makes sense to use it in specs. |
That's an interesting argument as there are already several attributes that uses WindowProxy in the spec. 👀 |
I think we should correct the type of attribute
opener
fromany
toWindowProxy?
since the current idl block is not describing the type of its definition concretely.The text was updated successfully, but these errors were encountered: