Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activation behavior for <input> never runs popover activation behavior #8982

Closed
nt1m opened this issue Mar 3, 2023 · 3 comments
Closed

Activation behavior for <input> never runs popover activation behavior #8982

nt1m opened this issue Mar 3, 2023 · 3 comments
Labels
topic: popover The popover attribute and friends

Comments

@nt1m
Copy link
Member

nt1m commented Mar 3, 2023

image

The early return in step 1 seems to cause the "popover activation behavior" to never run.

cc @josepharhar @mfreed7 @annevk @domenic
@nt1m nt1m added the topic: popover The popover attribute and friends label Mar 3, 2023
@josepharhar
Copy link
Contributor

If I'm reading the spec correctly, this means that if an input element has disabled or readonly it is not mutable and will not get the popover activation behavior.

I think that with disabled it makes sense to not run popover activation, but with readonly I'm not sure - but I also don't know why anyone would use readonly on the button input element types...

@annevk
Copy link
Member

annevk commented Mar 4, 2023

@nt1m note that <input type=button> is considered mutable. Not the best term.

@nt1m
Copy link
Member Author

nt1m commented Mar 8, 2023

Hmm, ok I guess this is fine then.

@nt1m nt1m closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: popover The popover attribute and friends
Milestone
No milestone
Development

No branches or pull requests
3 participants
@annevk @nt1m @josepharhar