Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify definition panel styles #139

Open
domenic opened this issue Aug 28, 2019 · 1 comment
Open

Unify definition panel styles #139

domenic opened this issue Aug 28, 2019 · 1 comment

Comments

@domenic
Copy link
Member

domenic commented Aug 28, 2019

Currently, we are using the Bikeshed-generated .dfn-panel, which is styled via inline styles, on most specs. We are then using the Wattsi-generated .dfnPanel, which is styled via standard.css, on HTML.

We should instead be using a uniform class name, with styles in standard.css (and no inline styles). Probably the best path is to:

  • Modify standard.css to style .dfn-panel instead of .dfnPanel. (Do not merge until the next step is complete... or maybe better, have a period where both are present.)
  • Change HTML/Wattsi to use .dfn-panel.
  • Revive https://github.com/tabatkins/bikeshed/pull/1287/files so that it removes the inline styling for .dfn-panel, instead letting standard.css take care of it.
@annevk
Copy link
Member

annevk commented Mar 25, 2020

There's a corresponding issue in that definition panels also come with script (script-dfn-panel), but we could tackle that separately probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants