Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching pattern for aac (and aac with ID3) in adts stream #114

Open
corneldamian opened this issue Dec 20, 2019 · 2 comments
Open

Matching pattern for aac (and aac with ID3) in adts stream #114

corneldamian opened this issue Dec 20, 2019 · 2 comments

Comments

@corneldamian
Copy link

There is no way in "Matching an audio or video type pattern" to detect aac (in adts streams), only in m4a (mp4) containers. There should be a way to detect the adts streams and more, to detect adts stream when they have a id3 metadata at the beginning. Right now all the audio files starting with id3 are considered mp3, which it's wrong. Apple it's using id3 even on some mp4 files.
I think, when id3 it's detected, the checker should skip until the end of id3 container and then start detection for aac and mp3 like it will try to match mp3 without id3.

Thanks

@annevk
Copy link
Member

annevk commented Jan 2, 2020

Are browsers exhibiting this behavior somehow?

@GPHemsley
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants