Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotificationEvent's constructor's second argument should not be optional #58

Closed
ehsan opened this issue Jan 11, 2016 · 1 comment
Closed

NotificationEvent's constructor's second argument should not be optional #58

ehsan opened this issue Jan 11, 2016 · 1 comment

Comments

@ehsan
Copy link

ehsan commented Jan 11, 2016

NotificationEventInit is a dictionary with a required notification member. As such, script cannot avoid passing the NotificationEventInit dictionary to the NotificationEvent constructor, so it should not be marked as optional.
@annevk annevk closed this as completed in adefcaf Jan 12, 2016
@annevk
Copy link
Member

annevk commented Jan 12, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ehsan @annevk