Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Editorial: avoid setting encoding multiple times
- Loading branch information
Showing
1 changed file
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b385374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem editorial to me...
b385374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is it observable?
b385374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, any change to the algorithm is non-editorial, regardless of whether it's observable in the final output. And besides, if it wasn't observable, why concern yourself with the fact that you're "setting encoding multiple times"?
b385374
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we'll have to disagree on that. Refactoring algorithms is fine and is considered editorial unless it affects implementations.