Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"basic URL parser" doesn't special-case the empty string as input #320

Closed
GPHemsley opened this issue Jun 3, 2017 · 1 comment
Closed

Comments

@GPHemsley
Copy link
Member

If input to "basic URL parser" is the empty string, the algorithm is able to make it all the way through to the end, since there is no special check for empty string. That essentially means it returns a URL with all default values.

If that URL is then passed to "URL serializer", it returns : (just U+003A (:)).

Is this all expected behavior? It seems to me like it wouldn't be.

@GPHemsley
Copy link
Member Author

GPHemsley commented Jun 4, 2017

Nevermind, the algorithm correctly transitions from "scheme start state" to "no scheme state" (where it fails if there is no base) to "relative state" (where it sets everything to match the base).

My implementation was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant