Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on URL.host setter's behavior #75

Closed
tyoshino opened this issue Nov 26, 2015 · 2 comments
Closed

Clarification on URL.host setter's behavior #75

tyoshino opened this issue Nov 26, 2015 · 2 comments

Comments

@tyoshino
Copy link
Member

Raised at https://code.google.com/p/chromium/issues/detail?id=551901

It's confusing that the host getter gives us:

  • "host:port" (for non-default port)
  • "host" (for default port)

while the host setter handles input without port as a host-only modification operation.

The spec should include some notes to prevent misuse.

For the host setter, for example ... hard to phrase correctly ...:


Note: Unlike the host getter, a value without a port does not mean implication of the default port. I.e. the host setter does nothing on url's port if the given value does not contain a port.


@annevk annevk closed this as completed in 99a85f7 Nov 26, 2015
@annevk
Copy link
Member

annevk commented Nov 26, 2015

Thank you!

@tyoshino
Copy link
Member Author

Looks good! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants