Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix send() charset overriding to use new MIME type infrastructure #188

Closed
domenic opened this issue Feb 4, 2018 · 2 comments
Closed

Fix send() charset overriding to use new MIME type infrastructure #188

domenic opened this issue Feb 4, 2018 · 2 comments

Comments

@domenic
Copy link
Member

domenic commented Feb 4, 2018

This is a known issue but I don't see a tracking bug. Basically,

Otherwise, if the header whose name is a byte-case-insensitive match for Content-Type in author request headers has a value that is a valid MIME type, which has a charset parameter whose value is not a byte-case-insensitive match for encoding, and encoding is not null, then set all the charset parameters whose value is not a byte-case-insensitive match for encoding of that header’s value to encoding.

should be done in terms of MIME Type parsing and serialization.

I'm especially wondering what to do if parsing fails.

@domenic
Copy link
Member Author

domenic commented Feb 4, 2018

https://github.com/w3c/web-platform-tests/blob/master/xhr/send-content-type-charset.htm will need to be updated when this gets fixed; it currently assumes that multiple parameters with the same name ("charset") will survive a roundtrip.

@annevk
Copy link
Member

annevk commented Feb 5, 2018

This is #176. It has tests too, but nobody is reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants