-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeSelector.Button error #33
Comments
I think the error on the demo page is because the example pulls in Highstock 6.0 from the CDN (due to an oversight), which is a version I haven't officially supported yet. There may still be a different issue with range selector buttons with Highstock 5.0.x though, I'll take a look. Which version of Highstock are you seeing this error with? |
First, I just wanted to say thank you for the amazingly fast response and AWESOME project you have created here. :) I just did
when I started my project a few days ago not thinking about versions, and it looks like I got 6.0.1. That would certainly explain the issue. |
No worries, that's what it said in the readme after all! (I've corrected that now). Glad you like the project! |
So does switching to Highcharts 5.x.x fix the issue? Can I close this? |
I haven't had a chance to check yet, sorry. :( Once I implemented my work around with the button array via a prop, I just moved on. I will let you know as soon as I can. |
I can't focus (click inside) neither on the examples or my own project's RangeSelector.Input. After some try and failure i figured out that it is possible to click right only in the edges of the inputs, but not on other areas |
@marcelobaez that issue with |
Confident this was fixed in 46a9666. |
For me, this issue is still a problem. We have a set of dates on our chart as seen in the link in the OP. I can click on the field with a date and see my cursor in the field but I can't change anything and the calendar doesn't come up either. Here is my entire RangeSelector code:
|
The RangeSelector.Button component doesn't seem to be working properly. You can actually see an example of the JS error in your demo:
https://whawker.github.io/react-jsx-highcharts/examples/Highstocks/index.html
If you include any kind of RangeSelector.Button in your code like this:
You'll end up with this error:
My "fix" for the time being is to just pass the buttons in like this:
<RangeSelector buttons={myArrayOfButtonsHere}></<RangeSelector>
The text was updated successfully, but these errors were encountered: