Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newline characters in selections can appear in link titles #24

Closed
wheelercj opened this issue May 23, 2024 · 0 comments
Closed

Newline characters in selections can appear in link titles #24

wheelercj opened this issue May 23, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@wheelercj
Copy link
Owner

Describe the bug
With the "When creating markdown of a selection, create a link with the selected text as the title" setting, if multiple unordered list items of text are selected and the "Copy markdown of selection" context menu option is used, the resulting markdown link will have a newline character in it, which breaks the markdown syntax of the link.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://en.wikipedia.org/wiki/Main_Page
  2. Select multiple items in an unordered list
  3. Right-click the selection and choose "Copy markdown of selection"
  4. Paste the markdown
  5. See that the pasted markdown spans multiple lines, and so is not a valid markdown link.

Expected behavior
The newline characters should be removed, maybe replaced with spaces.

Environment

  • Browser: all
@wheelercj wheelercj added the bug Something isn't working label May 23, 2024
@wheelercj wheelercj self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant