Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the docker alias in the readme to use {HOME} rather than ~ #482

Closed
zesoft23 opened this issue Apr 25, 2020 · 3 comments
Closed

Change the docker alias in the readme to use {HOME} rather than ~ #482

zesoft23 opened this issue Apr 25, 2020 · 3 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Milestone

Comments

@zesoft23
Copy link

Hey folks,

The current alias uses ~/.config/whipper in the first mount target. The "" around the alias prevents tilde expansion and results in:

docker: Error response from daemon: invalid mount config for type "bind": invalid mount path: '~/.config/whipper' mount path must be absolute.

Changing this to {HOME}/.config/whipper fixes the issue. Would y'all be willing to make that change in the README? I can make a PR if desired!

For reference here's the current alias:

alias whipper="docker run -ti --rm --device=/dev/cdrom \
    --mount type=bind,source=~/.config/whipper,target=/home/worker/.config/whipper \
    --mount type=bind,source=${PWD}/output,target=/output \
    whipperteam/whipper"
@github-actions
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@zesoft23
Copy link
Author

I'm on Debian 10 using GNU bash, version 5.0.3(1)-release (x86_64-pc-linux-gnu)
by the way!

You can recreate it by running:

docker pull whipperteam/whipper

Adding this to .bash_aliases

alias whipper="docker run -ti --rm --device=/dev/cdrom \
    --mount type=bind,source=~/.config/whipper,target=/home/worker/.config/whipper \
    --mount type=bind,source=${PWD}/output,target=/output \
    whipperteam/whipper"

Running:
mkdir -p ~/.config/whipper "${PWD}"/output

And then:

whipper -v

This is the docker section of the README

@JoeLametta JoeLametta added the Bug Generic bug: can be used together with more specific labels label May 29, 2020
@JoeLametta
Copy link
Collaborator

Fixed, thanks for reporting the issue!

@JoeLametta JoeLametta added the Accepted Accepted issue on our roadmap label May 29, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels
Projects
None yet
Development

No branches or pull requests

2 participants