Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line flags need a way to negate/flip behavior #577

Open
eharris opened this issue Sep 21, 2022 · 0 comments
Open

Command line flags need a way to negate/flip behavior #577

eharris opened this issue Sep 21, 2022 · 0 comments

Comments

@eharris
Copy link

eharris commented Sep 21, 2022

There are some command line flags that enable certain options, but there doesn't seem to be a way to disable that option on the command line if it is enabled in the config file.

For instance whipper cd rip --keep-going does not have a way to disable that option on the command line if it is enabled in the config file.

Example use case:
I have a couple of different CD drives I use to rip, and one of them is affected by the cdparanoia bug with drives with high read offset (see #234), so I have to use the buggy version of cdparanoia to be able to use that drive. I only use that drive when I'm trying to speed up the rip process of multiple CD's, and I only keep the results if the rip is completely error free, otherwise I re-rip it in the other more reliable drive.

Because the more reliable drive is the drive I use most often, I have keep_going = True in my whipper.conf file. But when I'm using the less reliable drive, I want it to stop immediately if it has a problem since I'm not going to keep the results of that rip anyway, but there's no way currently to disable that option on the command line.

An alternative for this specific case would be to allow the keep_going option to be in the drive specific config block, and have its presence there override the one in the [whipper.cd.rip] config block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant