Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor support #39

Open
whirvis opened this issue May 29, 2022 · 1 comment
Open

Add sensor support #39

whirvis opened this issue May 29, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request module-device Issue relates to the device modules module-hid-usb Issue relates to the HID & USB modules

Comments

@whirvis
Copy link
Owner

whirvis commented May 29, 2022

An I/O feature representing sensors such as accelerometers and gyroscopes should be added when possible to the controller module. The class of the I/O feature may be named Sensor or PhysicalSensor, and its state class SensorValue. The state class shall have a method named getValue(), which returns a Vector3fc containing the current value for the sensor. It shall also have shorthand methods like getX(), getY(), and getZ() which can be found in StickPos.

Device classes which may have an accelerometer and gyroscope feature could be, but are not limited to: Ps3Controller, Ps4Controller, Ps5Controller, Wiimote, NxLeftJoyCon, NxRightJoyCon, and NxProController.

EDIT: Removed XboxController from the list of candidates, as it has no accelerometer or gyroscope.

@whirvis whirvis added enhancement New feature or request module-device Issue relates to the device modules labels May 29, 2022
@whirvis whirvis self-assigned this May 29, 2022
@whirvis whirvis added the module-hid-usb Issue relates to the HID & USB modules label May 29, 2022
@whirvis
Copy link
Owner Author

whirvis commented May 29, 2022

While not fully implemented, the feature GenericSensor with state SensorValueZ / SensorValue has been added in commit 87915a0. A later version of Ketill will fully support these features. At which point, this issue will be closed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module-device Issue relates to the device modules module-hid-usb Issue relates to the HID & USB modules
Projects
None yet
Development

No branches or pull requests

1 participant